Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT menu development for 14_1_X (1/N) #46144

Merged
merged 1 commit into from
Oct 1, 2024
Merged

HLT menu development for 14_1_X (1/N) #46144

merged 1 commit into from
Oct 1, 2024
+1,891 −2,198

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 28, 2024 •
edited
Loading

backport of #46139

PR description:

Development of HLT menus for CMSSW_14_1_X

  • This is the PR for the 14_1_X branch which is the release cycle currently used for Run-3 HLT-menu development.

This update includes the integration of the following changes (6e09c53):

  • migration of the combined HLT table and related subtables to the CMSSW_14_1_0 confDB template;
  • removal of now useless customization functions related to CMSSW_14_1_X developments;

PR validation:

TSG Integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #46139 to the 2024 HIon production cycle (CMSSW_14_1_X)

@mmusich
HLT menu development for 14_1_X
6e09c53 
This update includes the integration of the following changes:
- migration of the combined HLT table and related subtables to CMSSW_14_1_0
- removal of now useless customization functions related to CMSSW_14_1_X developments
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Sep 28, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2024 •
edited
Loading

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 28, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Sep 28, 2024

type hlt-integration

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 904KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-495b8c/41799/summary.html
COMMIT: 6e09c53
CMSSW: CMSSW_14_1_X_2024-09-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46144/41799/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-495b8c/41799/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-495b8c/41799/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 140 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 22727 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331156
  • DQMHistoTests: Total failures: 66449
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3264686
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.005 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.001 KiB HLT/Filters
  • DQMHistoSizes: changed ( 140.063 ): 0.012 KiB JetMET/SUSYDQM
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 7 / 42 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Sep 29, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 40eedd1 into cms-sw:CMSSW_14_1_X Oct 1, 2024
9 checks passed
@mmusich mmusich deleted the HLTdevelopment141X branch October 1, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved hlt-integration orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
3 participants
@mmusich @cmsbuild @antoniovilela